-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES256K support #90
Conversation
Hello @imirkin. Could you please try to rebase master branch to this one? This would allow to retrieve changes with the newest CI strategy (based on Github action), so that it could be checked if checks pass on your PR? |
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 77.58% 76.41% -1.17%
==========================================
Files 60 57 -3
Lines 5648 5322 -326
==========================================
- Hits 4382 4067 -315
+ Misses 1266 1255 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. I will add @sergio-correia for further inspection, but code is pretty clean IMHO.
@sergio-correia : In my opinion, this looks good. Please, provide your feedback when possible |
Looks good to me, thanks. |
Unfortunately it doesn't seem like RFC 8812 provides any "worked" examples, unlike some of the other RFCs. This roundtrips successfully with the implementation I recently added to github.com/lestrrat-go/jwx.
There's also a libsecp256k1 library from the bitcoin project (https://github.com/bitcoin-core/secp256k1). However it doesn't seem to have a stable release, and it's unclear that the extra dependency would be worth it over openssl for this usage.
If this is accepted, I'd be happy to add EdDSA and x25519/x448 curve support.